Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monopole SKIM preparation for Run 3 #45134

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Monopole SKIM preparation for Run 3 #45134

merged 2 commits into from
Jul 4, 2024

Conversation

ThOliveira23
Copy link
Contributor

PR description:

Provide an update to the trigger paths to be employed in the MONOPOLE SKIM file for the Run 3. The additional inclusion of trigger paths associated with MET can be mentioned.
Additionally, the inclusion of the EXOMONOPOLE SKIM file to be executed in the MET and JetMET datasets for the Run 3.

PR validation:
The PR was validated through the the basic test procedure available in the CMSSW PR instructions

FYI: @malbouis, @srimanob, @CarstenHensel

@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Jun 4, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45134/40474

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2024

A new Pull Request was created by @ThOliveira23 for master.

It involves the following packages:

  • Configuration/Skimming (pdmv)

@AdrianoDee, @miquork, @cmsbuild, @sunilUIET can you please review it and eventually sign? Thanks.
@youyingli, @Martin-Grunewald, @fabiocos, @missirol this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Jun 4, 2024

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2024

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2876f5/39698/summary.html
COMMIT: 77dd38e
CMSSW: CMSSW_14_1_X_2024-06-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45134/39698/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338862
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338836
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2876f5/39707/summary.html
COMMIT: 77dd38e
CMSSW: CMSSW_14_1_X_2024-06-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45134/39707/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338862
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3338833
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45134/40522

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2024

Pull request #45134 was updated. @miquork, @cmsbuild, @AdrianoDee, @sunilUIET can you please check and sign again.

@ThOliveira23 ThOliveira23 changed the title [14_0_X] Monopole SKIM preparation for Run 3 Monopole SKIM preparation for Run 3 Jun 7, 2024
@ThOliveira23
Copy link
Contributor Author

Dear @cms-sw/pdmv-l2 could you kindly review and sign this PR. We would like to have it for the restart of the pp data taking starting period.

@tvami
Copy link
Contributor

tvami commented Jun 7, 2024

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2876f5/39788/summary.html
COMMIT: 6b038bc
CMSSW: CMSSW_14_1_X_2024-06-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45134/39788/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338974
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338954
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

+Upgrade

@youyingli
Copy link
Contributor

Hi @cms-sw/pdmv-l2, could you please sign this PR?

@sunilUIET
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2d2758e into cms-sw:master Jul 4, 2024
11 checks passed
@cmsbuild cmsbuild mentioned this pull request Jul 5, 2024
Merged
@ThOliveira23 ThOliveira23 mentioned this pull request Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved fully-signed orp-approved pdmv-approved tests-approved
Projects
None yet
Milestone
CMSSW_14_1_X
Development

Successfully merging this pull request may close these issues.
9 participants
@ThOliveira23 @cmsbuild @tvami @smuzaffar @srimanob @youyingli @sunilUIET @antoniovilela @ThOliveira